volume label fix, and logging fix

This commit is contained in:
billypom on debian 2025-03-14 20:35:06 -04:00
parent 2efe108f8c
commit 645c67dd37
3 changed files with 20 additions and 16 deletions

28
main.py
View File

@ -10,7 +10,7 @@ from mutagen.id3._frames import APIC
from configparser import ConfigParser from configparser import ConfigParser
import traceback import traceback
import DBA import DBA
from logging import debug from logging import debug, error, warning, basicConfig, INFO, DEBUG
from ui import Ui_MainWindow from ui import Ui_MainWindow
from PyQt5.QtWidgets import ( from PyQt5.QtWidgets import (
QFileDialog, QFileDialog,
@ -121,7 +121,7 @@ class Worker(QRunnable):
traceback.print_exc() traceback.print_exc()
exctype, value = sys.exc_info()[:2] exctype, value = sys.exc_info()[:2]
self.signals.signal_finished.emit((exctype, value, traceback.format_exc())) self.signals.signal_finished.emit((exctype, value, traceback.format_exc()))
logging.error( error(
f"Worker failed: {exctype} | {value} | {traceback.format_exc()}" f"Worker failed: {exctype} | {value} | {traceback.format_exc()}"
) )
else: else:
@ -326,7 +326,7 @@ class ApplicationWindow(QMainWindow, Ui_MainWindow):
"""Sets the ID3 tag APIC (album art) for all selected song filepaths""" """Sets the ID3 tag APIC (album art) for all selected song filepaths"""
selected_songs = self.tableView.get_selected_songs_filepaths() selected_songs = self.tableView.get_selected_songs_filepaths()
for song in selected_songs: for song in selected_songs:
logging.info( debug(
f"main.py set_album_art_for_selected_songs() | updating album art for {song}" f"main.py set_album_art_for_selected_songs() | updating album art for {song}"
) )
self.update_album_art_for_song(song, album_art_path) self.update_album_art_for_song(song, album_art_path)
@ -372,16 +372,16 @@ class ApplicationWindow(QMainWindow, Ui_MainWindow):
debug(audio) debug(audio)
if "APIC:" in audio: if "APIC:" in audio:
del audio["APIC:"] del audio["APIC:"]
logging.info("Deleting album art") debug("Deleting album art")
audio.save() audio.save()
else: else:
logging.warning( warning(
"delete_album_art_for_current_song() | no tag called APIC" "delete_album_art_for_current_song() | no tag called APIC"
) )
except Exception: except Exception:
traceback.print_exc() traceback.print_exc()
exctype, value = sys.exc_info()[:2] exctype, value = sys.exc_info()[:2]
logging.error( error(
f"delete_album_art_for_current_song() | Error processing this file:\t {file}\n{exctype}\n{value}\n{traceback.format_exc()}" f"delete_album_art_for_current_song() | Error processing this file:\t {file}\n{exctype}\n{value}\n{traceback.format_exc()}"
) )
@ -426,9 +426,9 @@ class ApplicationWindow(QMainWindow, Ui_MainWindow):
try: try:
self.current_volume = self.volumeSlider.value() self.current_volume = self.volumeSlider.value()
self.player.setVolume(self.current_volume) self.player.setVolume(self.current_volume)
self.volumeLabel = str(self.current_volume) self.volumeLabel.setText(str(self.current_volume))
except Exception as e: except Exception as e:
logging.error(f"main.py volume_changed() | Changing volume error: {e}") error(f"main.py volume_changed() | Changing volume error: {e}")
def speed_changed(self, rate: int) -> None: def speed_changed(self, rate: int) -> None:
"""Handles playback speed changes""" """Handles playback speed changes"""
@ -450,10 +450,10 @@ class ApplicationWindow(QMainWindow, Ui_MainWindow):
def on_previous_clicked(self) -> None: def on_previous_clicked(self) -> None:
"""""" """"""
logging.info("main.py on_previous_clicked()") debug("main.py on_previous_clicked()")
def on_next_clicked(self) -> None: def on_next_clicked(self) -> None:
logging.info("main.py on_next_clicked()") debug("main.py on_next_clicked()")
def add_latest_playlist_to_tree(self) -> None: def add_latest_playlist_to_tree(self) -> None:
"""Refreshes the playlist tree""" """Refreshes the playlist tree"""
@ -587,15 +587,15 @@ if __name__ == "__main__":
with open("utils/init.sql", "r") as file: with open("utils/init.sql", "r") as file:
lines = file.read() lines = file.read()
for statement in lines.split(";"): for statement in lines.split(";"):
logging.info(f"executing [{statement}]") debug(f"executing [{statement}]")
db.execute(statement, ()) db.execute(statement, ())
# logging setup # logging setup
file_handler = logging.FileHandler(filename="log", encoding="utf-8") file_handler = logging.FileHandler(filename="log", encoding="utf-8")
stdout_handler = logging.StreamHandler(stream=sys.stdout) stdout_handler = logging.StreamHandler(stream=sys.stdout)
handlers = [file_handler, stdout_handler] handlers = [file_handler, stdout_handler]
# logging.basicConfig(filename="log", encoding="utf-8", level=logging.DEBUG) # basicConfig(filename="log", encoding="utf-8", level=logging.DEBUG)
logging.basicConfig( basicConfig(
level=logging.INFO, level=DEBUG,
format="[%(asctime)s] {%(filename)s:%(lineno)d} %(levelname)s - %(message)s", format="[%(asctime)s] {%(filename)s:%(lineno)d} %(levelname)s - %(message)s",
handlers=handlers, handlers=handlers,
) )

3
ui.py
View File

@ -195,7 +195,8 @@ class Ui_MainWindow(object):
self.hLayoutControls2.setSpacing(6) self.hLayoutControls2.setSpacing(6)
self.hLayoutControls2.setObjectName("hLayoutControls2") self.hLayoutControls2.setObjectName("hLayoutControls2")
self.volumeSlider = QtWidgets.QSlider(self.centralwidget) self.volumeSlider = QtWidgets.QSlider(self.centralwidget)
self.volumeSlider.setMaximum(100) self.volumeSlider.setMinimum(-1)
self.volumeSlider.setMaximum(101)
self.volumeSlider.setProperty("value", 50) self.volumeSlider.setProperty("value", 50)
self.volumeSlider.setOrientation(QtCore.Qt.Horizontal) self.volumeSlider.setOrientation(QtCore.Qt.Horizontal)
self.volumeSlider.setTickPosition(QtWidgets.QSlider.TicksAbove) self.volumeSlider.setTickPosition(QtWidgets.QSlider.TicksAbove)

5
ui.ui
View File

@ -353,8 +353,11 @@
</property> </property>
<item> <item>
<widget class="QSlider" name="volumeSlider"> <widget class="QSlider" name="volumeSlider">
<property name="minimum">
<number>-1</number>
</property>
<property name="maximum"> <property name="maximum">
<number>100</number> <number>101</number>
</property> </property>
<property name="value"> <property name="value">
<number>50</number> <number>50</number>